Skip to content

chore(app): misc changes #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ruwanidealwis wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore(app): misc changes #356

ruwanidealwis wants to merge 5 commits into from

Conversation

@ruwanidealwis
Copy link
Contributor

@ruwanidealwis ruwanidealwis commented Dec 7, 2022 •
edited
Loading

Short Description

  • Updates favicon
  • Send CAL Logo in our emails
  • allows reuse of emails
  • fixes unassigned resource search
  • Create a new project with Not Started

Link to Issue

  • Fixes { issue-id }

Screenshots (if applicable)

Screen Shot 2022-12-07 at 6 59 08 PM

Screen Shot 2022-12-07 at 6 59 20 PM

Screen Shot 2022-12-07 at 7 41 21 PM

Acceptance Criteria

  • My PR commit name matches feat/chore/bug: (config/frontend/api): message
  • I have ran a lint on my relevant project directory and fixed all fixable issues
  • I have crossed off all task items linked to the issue
  • I have added/updated any relevant documentation related to my code, if exists
  • I have added relevant tests to the code
  • I have removed all unused styles from my code, if applicable
  • I have replaced all hardcoded strings from my code, if applicable

AmanRiat1
AmanRiat1 approved these changes Dec 11, 2022
View reviewed changes
Copy link
Contributor

@AmanRiat1 AmanRiat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for doing this and lgtm!

@MustafaAli789
Copy link
Contributor

MustafaAli789 commented Dec 12, 2022

gosh ruwani
image

MustafaAli789
MustafaAli789 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@MustafaAli789 MustafaAli789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AmanRiat1 AmanRiat1 AmanRiat1 approved these changes

@MustafaAli789 MustafaAli789 MustafaAli789 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ruwanidealwis @MustafaAli789 @AmanRiat1