Skip to content

ci: keep tests-only; remove coverage and security workflows #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Slokh merged 4 commits into from
Feb 26, 2026
Merged

ci: keep tests-only; remove coverage and security workflows #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36ff78e
ci: add coverage (cargo-llvm-cov) with 85% gate; add security checks …
Slokh Feb 26, 2026
330e75a
fix(ci): replace spaces with tab in Makefile coverage target
Slokh Feb 26, 2026
277b98f
fix: silence dead_code for OsKeychain on non-macOS test builds; keep …
Slokh Feb 26, 2026
c15d741
ci: drop coverage and security workflows; keep tests-only pipeline; r…
Slokh Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,7 @@ fix:
# Run e2e tests against live mpp-proxy (requires funded wallet)
e2e: build
cargo test --test live -- --ignored --nocapture
# Generate coverage locally (requires cargo-llvm-cov and llvm-tools-preview)
# Install once: `rustup component add llvm-tools-preview` and `cargo install cargo-llvm-cov`
coverage:
cargo llvm-cov --all-features --workspace --fail-under-lines 85 --lcov --output-path lcov.info
2 changes: 2 additions & 0 deletions src/wallet/keychain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,10 @@ pub trait KeychainBackend: Send + Sync {
/// OS keychain backend using platform-native secret storage.
///
/// Currently supports macOS only (via `security-framework`).
#[cfg_attr(all(test, not(target_os = "macos")), allow(dead_code))]
pub struct OsKeychain;

#[cfg_attr(all(test, not(target_os = "macos")), allow(dead_code))]
impl KeychainBackend for OsKeychain {
fn get(&self, profile: &str) -> Result<Option<Zeroizing<String>>> {
#[cfg(target_os = "macos")]
Expand Down