chore(precompiles): update checkpoint_commit signature for LIFO assertion#321
Draft
chore(precompiles): update checkpoint_commit signature for LIFO assertion#321
Conversation
…tion Pass JournalCheckpoint through checkpoint_commit() to match upstream trait change from tempoxyz/tempo#3094. Co-Authored-By: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com>
decofe
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
Co-Authored-By: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com>
0xrusowsky
approved these changes
Mar 11, 2026
zerosnacks
added
the
S-blocked
Contributor
|
tagged as blocked until tempoxyz/tempo#3094 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
PrecompileStorageProvider::checkpoint_commitsignature to acceptJournalCheckpoint, matching upstream trait change from tempoxyz/tempo#3094.Motivation
Upstream changed
checkpoint_commit(&mut self)→checkpoint_commit(&mut self, checkpoint: JournalCheckpoint)to enable LIFO ordering assertions on nested checkpoints. Both foundry impls (anvil + evm-core) are stubs, so the parameter is unused but required to satisfy the trait.Changes
crates/anvil/src/eth/backend/tempo.rs— add_checkpoint: JournalCheckpointparamcrates/evm/core/src/tempo.rs— add_checkpoint: JournalCheckpointparamPrompted by: rusowsky