Open
Conversation
grandizzy
changed the title
Adds a test case that calls eth_fillTransaction directly with an expiring nonce (nonceKey=MAX). This catches the bug where the node overwrites nonce=0 by reading from storage, causing the error: 'expiring nonce transaction must have nonce == 0' This is a regression test for tempo#2491. Ref: https://tempoxyz.slack.com/archives/C09KCGR4LQ4/p1770314532776229 Amp-Thread-ID: https://ampcode.com/threads/T-019c2f0d-9905-72f8-95d9-0bb5ca634d18 Co-authored-by: Amp <amp@ampcode.com>
decofe
force-pushed
the
test-eth-fill-transaction-expiring-nonce
branch
from
f6b5b3b to
c9012cd
Compare
- Add || true to prevent set -euo pipefail from killing script on cast rpc error - Use block timestamp instead of date +%s to avoid CI/devnet clock skew - Remove invalid keyType field (test account uses secp256k1, not p256) - Fix value field from 0x to 0x0 - Add catch-all error check for unexpected failures Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019ce6dd-576e-77ec-bcda-838db7e28d89
Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019ce6dd-576e-77ec-bcda-838db7e28d89
zerosnacks
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
Contributor
|
cc @grandizzy I believe this was prompted by you; I've updated the PR so it passed CI again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CI tests that calls
eth_fillTransactiondirectly.