docs: add bun tab to all install code-groups#452
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brendanjryan
force-pushed
the
docs/add-bun-install-tabs
branch
2 times, most recently
from
37017cc to
e718e0d
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecc653c7cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (let i = 0; i < lines.length; i++) { | ||
| // Look for a bash [npm] block that contains an install command | ||
| const line = lines[i]; | ||
| if (!/^```bash \[npm\]/.test(line)) continue; |
There was a problem hiding this comment.
checkInstallTabs only validates blocks after matching ````bash [npm], so an install code-group that accidentally omits the npm tab is skipped entirely. In that case the test passes even though the new policy requires all three tabs (npm`, `pnpm`, and `bun`), so this guardrail can miss real violations.
Useful? React with 👍 / 👎.
- Add missing bun tab to card and lightning payment method pages - Add AGENTS.md rule requiring npm, pnpm, and bun in install code-groups - Add vitest lint test to enforce the rule across all .mdx files
brendanjryan
force-pushed
the
docs/add-bun-install-tabs
branch
from
e718e0d to
f32c430
Compare
1 participant
Adds the missing
buntab to install code-groups incardandlightningpayment method pages.Changes
bun add mpp-cardtabbun add @buildonspark/lightning-mpp-sdktab.mdxfiles and fails if any install code-group is missing a tab