Add initial timestamp values into hour/minute/second inputs#3212
Open
Alex-Tideman wants to merge 4 commits intocodefreeze-03.02.26from
Open
Add initial timestamp values into hour/minute/second inputs#3212Alex-Tideman wants to merge 4 commits intocodefreeze-03.02.26from
Alex-Tideman wants to merge 4 commits intocodefreeze-03.02.26from
Conversation
Parse the existing filter ISO value back into date/time components when reopening a datetime filter chip. Also initialize the "add new filter" datetime inputs from persisted stores.
Move getInitialStart/getInitialEnd into a shared utility file and add 12 unit tests covering single datetime, BETWEEN ranges, timezone conversion, and edge cases.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| @@ -0,0 +1,66 @@ | |||
| import { startOfDay } from 'date-fns'; | |||
Contributor
There was a problem hiding this comment.
⚠️ Could not find a declaration file for module 'date-fns-tz'. '/home/runner/work/ui/ui/node_modules/.pnpm/date-fns-tz@1.3.8_date-fns@2.30.0/node_modules/date-fns-tz/index.js' implicitly has an 'any' type.
Contributor
|
|
Thanks for fixing this! |
laurakwhit
reviewed
Mar 6, 2026
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| import { addHours, addMinutes, addSeconds, startOfDay } from 'date-fns'; | |||
Contributor
There was a problem hiding this comment.
⚠️ Could not find a declaration file for module 'date-fns-tz'. '/home/runner/work/ui/ui/node_modules/.pnpm/date-fns-tz@1.3.8_date-fns@2.30.0/node_modules/date-fns-tz/index.js' implicitly has an 'any' type.
laurakwhit
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
When reopening a datetime filter chip (e.g., StartTime >= 3/5/26, 9:15:00 AM CST), the hour/minute/second inputs were empty instead of showing the previously set values.
Root cause: The dropdown-filter-chip.svelte component initialized its local time state to empty strings on every mount, never parsing the existing filter's ISO timestamp value back into date/time components.
Fix:
conversion, and edge cases
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?