Skip to content

Revert Count Schedules API #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rossedfort merged 4 commits into from
Feb 27, 2026
Merged

Revert Count Schedules API #3203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4b6388
Go back to using legacy API for schedule count
laurakwhit Feb 27, 2026
e6c0076
Merge branch 'main' into revert-schedule-count
rossedfort Feb 27, 2026
70055ac
fix mock API
rossedfort Feb 27, 2026
291eeca
fix
rossedfort Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions src/lib/services/workflow-counts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,17 +98,18 @@ export const fetchScheduleCount = async ({
namespace: string;
query?: string;
}): Promise<string> => {
try {
const countRoute = routeForApi('schedules.count', { namespace });
const { count } = await requestFromAPI<CountSchedulesResponse>(countRoute, {
params: query ? { query } : {},
notifyOnError: false,
});
return count ?? '0';
} catch (error: unknown) {
if (isNotImplemented(error) || isNotFound(error)) {
return fetchScheduleCountLegacy(namespace, query);
}
throw error;
}
return fetchScheduleCountLegacy(namespace, query);
// try {
// const countRoute = routeForApi('schedules.count', { namespace });
// const { count } = await requestFromAPI<CountSchedulesResponse>(countRoute, {
// params: query ? { query } : {},
// notifyOnError: false,
// });
// return count ?? '0';
// } catch (error: unknown) {
// if (isNotImplemented(error) || isNotFound(error)) {
// return fetchScheduleCountLegacy(namespace, query);
// }
// throw error;
// }
};
4 changes: 2 additions & 2 deletions tests/integration/schedule-edit.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { expect, test } from '@playwright/test';
import {
mockScheduleApi,
mockSchedulesApis,
SCHEDULES_COUNT_API,
WORKFLOWS_COUNT_API,
} from '~/test-utilities/mock-apis';

const schedulesUrl = '/namespaces/default/schedules';
Expand All @@ -18,7 +18,7 @@ test.describe('Schedules List with schedules', () => {
test('selects schedule and edits', async ({ page }) => {
await page.goto(schedulesUrl);

await page.waitForResponse(SCHEDULES_COUNT_API);
await page.waitForResponse(WORKFLOWS_COUNT_API);

const createButton = page.getByTestId('create-schedule');
await expect(createButton.first()).toBeEnabled();
Expand Down
6 changes: 3 additions & 3 deletions tests/integration/schedules-list.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { expect, test } from '@playwright/test';

import {
mockSchedulesApis,
SCHEDULES_COUNT_API,
WORKFLOWS_COUNT_API,
} from '~/test-utilities/mock-apis';

const schedulesUrl = '/namespaces/default/schedules';
Expand All @@ -17,7 +17,7 @@ test.describe('Schedules List with no schedules', () => {
}) => {
await page.goto(schedulesUrl);

await page.waitForResponse(SCHEDULES_COUNT_API);
await page.waitForResponse(WORKFLOWS_COUNT_API);
const namespace = page.locator('h1');
await expect(namespace).toHaveText('0 Schedules');

Expand All @@ -36,7 +36,7 @@ test.describe('Schedules List with schedules', () => {
}) => {
await page.goto(schedulesUrl);

await page.waitForResponse(SCHEDULES_COUNT_API);
await page.waitForResponse(WORKFLOWS_COUNT_API);
const namespace = page.locator('h1');
await expect(namespace).toHaveText('15 Schedules');

Expand Down
2 changes: 1 addition & 1 deletion tests/test-utilities/mock-apis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export const mockSchedulesApis = (
mockNamespaceApis(page),
mockSearchAttributesApi(page, customSearchAttributes),
mockSchedulesApi(page, empty),
mockSchedulesCountApi(page, emptySchedulesCount),
mockWorkflowsCountApi(page, emptySchedulesCount),
]);
};

Expand Down
Loading