Skip to content

Standalone Activities: add activity_ prefix to id_conflict/reuse_policy #9170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yuandrew wants to merge 1 commit into from
Closed

Standalone Activities: add activity_ prefix to id_conflict/reuse_policy #9170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions chasm/lib/activity/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@
func (h *handler) StartActivityExecution(ctx context.Context, req *activitypb.StartActivityExecutionRequest) (*activitypb.StartActivityExecutionResponse, error) {
frontendReq := req.GetFrontendRequest()

reusePolicy, ok := businessIDReusePolicyMap[frontendReq.GetIdReusePolicy()]
reusePolicy, ok := businessIDReusePolicyMap[frontendReq.GetActivityIdReusePolicy()]

Check failure on line 54 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / golangci 

frontendReq.GetActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdReusePolicy)

Check failure on line 54 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / lint-workflows 

frontendReq.GetActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdReusePolicy)

Check failure on line 54 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / lint-workflows 

frontendReq.GetActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdReusePolicy)

Check failure on line 54 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / Pre-build for cache 

frontendReq.GetActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdReusePolicy)

Check failure on line 54 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / build-docker-image 

frontendReq.GetActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdReusePolicy)
if !ok {
return nil, serviceerror.NewInvalidArgumentf("unsupported ID reuse policy: %v", frontendReq.GetIdReusePolicy())
return nil, serviceerror.NewInvalidArgumentf("unsupported ID reuse policy: %v", frontendReq.GetActivityIdReusePolicy())

Check failure on line 56 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / golangci 

frontendReq.GetActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdReusePolicy)

Check failure on line 56 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / lint-workflows 

frontendReq.GetActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdReusePolicy)

Check failure on line 56 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / lint-workflows 

frontendReq.GetActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdReusePolicy)

Check failure on line 56 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / Pre-build for cache 

frontendReq.GetActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdReusePolicy)

Check failure on line 56 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / build-docker-image 

frontendReq.GetActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdReusePolicy)
}

conflictPolicy, ok := businessIDConflictPolicyMap[frontendReq.GetIdConflictPolicy()]
conflictPolicy, ok := businessIDConflictPolicyMap[frontendReq.GetActivityIdConflictPolicy()]

Check failure on line 59 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / golangci 

frontendReq.GetActivityIdConflictPolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdConflictPolicy)

Check failure on line 59 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / lint-workflows 

frontendReq.GetActivityIdConflictPolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdConflictPolicy)

Check failure on line 59 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / Pre-build for cache 

frontendReq.GetActivityIdConflictPolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdConflictPolicy)

Check failure on line 59 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / build-docker-image 

frontendReq.GetActivityIdConflictPolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdConflictPolicy)
if !ok {
return nil, serviceerror.NewInvalidArgumentf("unsupported ID conflict policy: %v", frontendReq.GetIdConflictPolicy())
return nil, serviceerror.NewInvalidArgumentf("unsupported ID conflict policy: %v", frontendReq.GetActivityIdConflictPolicy())

Check failure on line 61 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / golangci 

frontendReq.GetActivityIdConflictPolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdConflictPolicy)

Check failure on line 61 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / lint-workflows 

frontendReq.GetActivityIdConflictPolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdConflictPolicy)

Check failure on line 61 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / Pre-build for cache 

frontendReq.GetActivityIdConflictPolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdConflictPolicy)

Check failure on line 61 in chasm/lib/activity/handler.go

View workflow job for this annotation

GitHub Actions / build-docker-image 

frontendReq.GetActivityIdConflictPolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdConflictPolicy)
}

result, err := chasm.StartExecution(
Expand Down
8 changes: 4 additions & 4 deletions chasm/lib/activity/validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,12 +166,12 @@
}

func normalizeAndValidateIDPolicy(req *workflowservice.StartActivityExecutionRequest) error {
if req.GetIdReusePolicy() == enumspb.ACTIVITY_ID_REUSE_POLICY_UNSPECIFIED {
req.IdReusePolicy = enumspb.ACTIVITY_ID_REUSE_POLICY_ALLOW_DUPLICATE
if req.GetActivityIdReusePolicy() == enumspb.ACTIVITY_ID_REUSE_POLICY_UNSPECIFIED {

Check failure on line 169 in chasm/lib/activity/validator.go

View workflow job for this annotation

GitHub Actions / golangci 

req.GetActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdReusePolicy)

Check failure on line 169 in chasm/lib/activity/validator.go

View workflow job for this annotation

GitHub Actions / lint-workflows 

req.GetActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdReusePolicy)

Check failure on line 169 in chasm/lib/activity/validator.go

View workflow job for this annotation

GitHub Actions / Pre-build for cache 

req.GetActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdReusePolicy)

Check failure on line 169 in chasm/lib/activity/validator.go

View workflow job for this annotation

GitHub Actions / build-docker-image 

req.GetActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdReusePolicy)
req.ActivityIdReusePolicy = enumspb.ACTIVITY_ID_REUSE_POLICY_ALLOW_DUPLICATE

Check failure on line 170 in chasm/lib/activity/validator.go

View workflow job for this annotation

GitHub Actions / golangci 

req.ActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method ActivityIdReusePolicy)

Check failure on line 170 in chasm/lib/activity/validator.go

View workflow job for this annotation

GitHub Actions / lint-workflows 

req.ActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method ActivityIdReusePolicy)

Check failure on line 170 in chasm/lib/activity/validator.go

View workflow job for this annotation

GitHub Actions / Pre-build for cache 

req.ActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method ActivityIdReusePolicy)

Check failure on line 170 in chasm/lib/activity/validator.go

View workflow job for this annotation

GitHub Actions / build-docker-image 

req.ActivityIdReusePolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method ActivityIdReusePolicy)
}

if req.GetIdConflictPolicy() == enumspb.ACTIVITY_ID_CONFLICT_POLICY_UNSPECIFIED {
req.IdConflictPolicy = enumspb.ACTIVITY_ID_CONFLICT_POLICY_FAIL
if req.GetActivityIdConflictPolicy() == enumspb.ACTIVITY_ID_CONFLICT_POLICY_UNSPECIFIED {

Check failure on line 173 in chasm/lib/activity/validator.go

View workflow job for this annotation

GitHub Actions / golangci 

req.GetActivityIdConflictPolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdConflictPolicy)

Check failure on line 173 in chasm/lib/activity/validator.go

View workflow job for this annotation

GitHub Actions / lint-workflows 

req.GetActivityIdConflictPolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdConflictPolicy)

Check failure on line 173 in chasm/lib/activity/validator.go

View workflow job for this annotation

GitHub Actions / Pre-build for cache 

req.GetActivityIdConflictPolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdConflictPolicy)

Check failure on line 173 in chasm/lib/activity/validator.go

View workflow job for this annotation

GitHub Actions / build-docker-image 

req.GetActivityIdConflictPolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method GetActivityIdConflictPolicy)
req.ActivityIdConflictPolicy = enumspb.ACTIVITY_ID_CONFLICT_POLICY_FAIL

Check failure on line 174 in chasm/lib/activity/validator.go

View workflow job for this annotation

GitHub Actions / golangci 

req.ActivityIdConflictPolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method ActivityIdConflictPolicy) (typecheck)

Check failure on line 174 in chasm/lib/activity/validator.go

View workflow job for this annotation

GitHub Actions / lint-workflows 

req.ActivityIdConflictPolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method ActivityIdConflictPolicy)

Check failure on line 174 in chasm/lib/activity/validator.go

View workflow job for this annotation

GitHub Actions / Pre-build for cache 

req.ActivityIdConflictPolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method ActivityIdConflictPolicy)

Check failure on line 174 in chasm/lib/activity/validator.go

View workflow job for this annotation

GitHub Actions / build-docker-image 

req.ActivityIdConflictPolicy undefined (type *workflowservice.StartActivityExecutionRequest has no field or method ActivityIdConflictPolicy)
}

return nil
Expand Down
Loading