Skip to content

Drop Ruby 3.2, support Ruby 4.0 #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cretz merged 2 commits into from
Jan 7, 2026
Merged

Drop Ruby 3.2, support Ruby 4.0 #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df9e543
Drop Ruby 3.2, support Ruby 4.0
cretz Jan 5, 2026
b4c3979
More specific steep ignores
cretz Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/build-gems.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ jobs:
- name: Setup Ruby and Rust
uses: oxidize-rb/actions/setup-ruby-and-rust@v1
with:
ruby-version: "3.4"
bundler-cache: true
ruby-version: "4.0"
bundler-cache: false # Needed so 'bundler install' doesn't run
cargo-cache: true
cargo-vendor: true
working-directory: ./temporalio
Expand All @@ -41,7 +41,8 @@ jobs:
id: cross-gem
working-directory: ./temporalio
run: |
bundle exec rb-sys-dock --platform ${{ matrix.rubyPlatform }} --ruby-versions "3.2,3.3,3.4" --mount-toolchains --build
gem install rb_sys --no-document
rb-sys-dock --platform ${{ matrix.rubyPlatform }} --ruby-versions "3.3,3.4,4.0" --mount-toolchains --build
Comment on lines -44 to +45
Copy link
Member Author

@cretz cretz Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to be changed from bundle exec because bundle exec did a bundle install which was leaking GH-runner-built gems into the rb-sys-dock container causing glibc mismatches

echo "gem-path=$(find pkg -name '*-${{ matrix.rubyPlatform }}.gem')" >> $GITHUB_OUTPUT

- name: Upload gem
Expand All @@ -62,7 +63,7 @@ jobs:
- name: Setup Ruby and Rust
uses: oxidize-rb/actions/setup-ruby-and-rust@v1
with:
ruby-version: "3.4"
ruby-version: "4.0"
bundler-cache: true
cargo-cache: true
cache-version: v1-source
Expand Down Expand Up @@ -96,7 +97,7 @@ jobs:
# does not have updated certificates and it is not easy to update them, see
# https://github.com/temporalio/sdk-ruby/issues/306
os: [ubuntu-latest, macos-latest]
rubyVersion: ["3.2", "3.3", "3.4"]
rubyVersion: ["3.3", "3.4", "4.0"]
# Container defaults to empty/none, but additional container for Alpine
# added later
container: [""]
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ jobs:
# https://github.com/temporalio/sdk-ruby/issues/172
os: [ubuntu-latest, macos-latest]
# Earliest and latest supported
rubyVersion: ["3.2", "3.4"]
rubyVersion: ["3.3", "4.0"]

include:
- os: ubuntu-latest
rubyVersion: "3.4"
rubyVersion: "4.0"
checkTarget: true
docsTarget: true
runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion temporalio/.rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ inherit_mode:

AllCops:
NewCops: enable
TargetRubyVersion: 3.2
TargetRubyVersion: 3.3
SuggestExtensions: false
Exclude:
- ext/**/*
Expand Down
Loading
Loading