Skip to content

Fix: load TLS certs from path if specified #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
THardy98 merged 1 commit into from
Jan 15, 2026
Merged

Fix: load TLS certs from path if specified #596

THardy98 merged 1 commit into from
Jan 15, 2026

Conversation

@THardy98
Copy link
Contributor

@THardy98 THardy98 commented Jan 15, 2026

What was changed

Read TLS paths from DataSource path if specified.

Literal changes:

  • Added GetBytes() method to DataSource that returns Data if set, or reads from Path using File.ReadAllBytes()
  • Changed ToTlsOptions() to use ?.GetBytes() instead of ?.Data

Why?

Bug fix

  1. Closes [Bug] Loading TLS certificates from path doesn't work #584

  2. How was this tested:
    Modified existing integration test

  3. Any docs updates needed?
    Don't think so

@THardy98
add GetBytes method to DataSource that returns Data if set, otherwise…
dbde84f 
… reads from Path using File.ReadAllBytes (ensures that we read from path if set
@THardy98 THardy98 requested a review from a team as a code owner January 15, 2026 17:32
@THardy98 THardy98 merged commit a0a70a1 into main Jan 15, 2026
11 checks passed
@THardy98 THardy98 deleted the envconfig-fix-tls-path branch January 15, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Loading TLS certificates from path doesn't work

3 participants

@THardy98 @Sushisource