Support for gRPC binary metadata headers #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaeagle99
commented
Dec 12, 2025
jmaeagle99
commented
Dec 12, 2025
cretz
approved these changes
Dec 12, 2025
Member
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
Nothing blocking, just pedantic overload stuff on internal things
cretz
approved these changes
Dec 12, 2025
Member
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
Looks great, thanks! (though as mentioned in comment, have to merge temporalio/sdk-core#1076 first and update submodule stuff here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Binary headers cannot be specified using the existing metadata APIs. These new APIs for client options and RPC options allow specifying the binary metadata headers.
Checklist
Closes [Feature Request] Ensure gRPC binary metadata headers are supported #512
How was this tested: Add tests and validate it works with new sdk-core update.
Any docs updates needed? Unsure, will check with team