Skip to content

Conversation

@jmaeagle99
Copy link
Contributor

@jmaeagle99 jmaeagle99 commented Dec 11, 2025

What was changed

  • Suppress performance analysis rule in API generator program.
  • Fix protos path within sdk-core submodule.
  • Regenerate protos based on current sdk-core submodule version.

Why?

I saw that the "Regen confirm unchanged" step of the CI workflow was failing silently. Example at https://github.com/temporalio/sdk-dotnet/actions/runs/20114313589/job/57719795349#step:7:21

  • The update to .NET 10 likely caused the code analysis warning that fails the compilation of the Temporalio.Api.Generator project.
  • After fixing the project compilation, the update to the latest sdk-core caused the project to not find the protos for regeneration since the crates were refactored.

Checklist

  • How was this tested: Will check CI workflow

@jmaeagle99 jmaeagle99 requested a review from a team as a code owner December 11, 2025 19:20
@jmaeagle99 jmaeagle99 merged commit 79d44c3 into temporalio:main Dec 12, 2025
35 of 38 checks passed
@jmaeagle99 jmaeagle99 deleted the proto-gen branch December 12, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants