Skip to content

Fix NR's count metric by using float rather than int #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taonic wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix NR's count metric by using float rather than int #94

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d4aec3
Fix NR's count metric by using float rather than int
taonic Nov 4, 2024
3177372
Merge branch 'main' into taonic/submit-float-count-to-nr
chaptersix Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions cloud/observability/promql-to-nr-ts/promql-to-nr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ const convertPrometheusCountToNewRelicCountMetrics = (
prometheusMetric.values.map((v) => ({
name: NEWRELIC_METRIC_PREFIX + metricName.split("_count")[0] + "_rate1m",
type: "count",
value: parseInt(v[1]),
value: parseFloat(v[1]),
timestamp: v[0],
"interval.ms": PROMETHEUS_STEP_SECONDS * 1000,
attributes: _.omit(prometheusMetric.metric, "__rollup__"),
Expand Down Expand Up @@ -284,16 +284,8 @@ const main = async () => {
main().catch((error) => {
console.log({
level: "error",
message: "Error in main loop. Closing healthcheck server.",
message: "Error in main loop. Shutting down metrics service.",
error,
});

server.close(() => {
console.log({
level: "info",
message: "Healthcheck server closed",
});

process.exit(1);
});
process.exit(1);
});