Support environment config on a single sample#392
Closed
cretz wants to merge 2 commits intotemporalio:mainfrom
Closed
Support environment config on a single sample#392cretz wants to merge 2 commits intotemporalio:mainfrom
cretz wants to merge 2 commits intotemporalio:mainfrom
Conversation
yuandrew
approved these changes
Aug 27, 2025
Contributor
yuandrew
left a comment
yuandrew
left a comment
There was a problem hiding this comment.
go.mod changes need to be cleaned up now that the feature is released, but LGTM otherwise
Contributor
|
Sample was incorporated into #420, closing as duplicate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
envconfig.MustLoadDefaultClientOptions()on a single sampleThis is #390 but just for one sample. This cannot be merged until temporalio/sdk-go#1849 is released but can be reviewed. The rest of the samples will come in a later PR when temporalio/cli#764 is released and the docs in this repo can be updated to show how to set the env vars or config file.