Skip to content

Fix nexus endpoint create error message #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dandavison merged 1 commit into from
Jul 8, 2025
Merged

Fix nexus endpoint create error message #822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions temporalcli/commands.operator_nexus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func (c *TemporalOperatorNexusEndpointCreateCommand) run(cctx *CommandContext, _
return err
}
if target == nil {
return fmt.Errorf("either --target-namespace and --target-task queue or --target-url are required")
return fmt.Errorf("either --target-namespace and --target-task-queue or --target-url are required")
}

cl, err := c.Parent.Parent.Parent.ClientOptions.dialClient(cctx)
Expand Down Expand Up @@ -253,7 +253,7 @@ func (c *TemporalOperatorNexusEndpointCommand) endpointTargetFromArgs(namespace,
},
}, nil
}
return nil, fmt.Errorf("either --target-namespace and --target-task queue or --target-url are required")
return nil, fmt.Errorf("either --target-namespace and --target-task-queue or --target-url are required")
}

func (c *TemporalOperatorNexusEndpointCommand) getEndpointByName(ctx context.Context, cl client.Client, name string) (*nexuspb.Endpoint, error) {
Expand Down
4 changes: 2 additions & 2 deletions temporalcli/commands.operator_nexus_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ func (s *SharedServerSuite) TestCreateNexusEndpoint_Target() {

s.T().Run("NoTarget_FailsValidation", func(t *testing.T) {
res := s.Execute("operator", "nexus", "endpoint", "create", "--name", validEndpointName(t))
require.ErrorContains(t, res.Err, "either --target-namespace and --target-task queue or --target-url are required")
require.ErrorContains(t, res.Err, "either --target-namespace and --target-task-queue or --target-url are required")
})

s.T().Run("NoTaskQueue_FailsValidation", func(t *testing.T) {
Expand All @@ -45,7 +45,7 @@ func (s *SharedServerSuite) TestCreateNexusEndpoint_Target() {
"--name", validEndpointName(t),
"--target-task-queue", "tq",
)
require.ErrorContains(t, res.Err, "either --target-namespace and --target-task queue or --target-url are required")
require.ErrorContains(t, res.Err, "either --target-namespace and --target-task-queue or --target-url are required")
})

s.T().Run("WorkerTarget_Accepted", func(t *testing.T) {
Expand Down