Console Print url format mismatch bug fixed#803
Console Print url format mismatch bug fixed#803maniram-yadav wants to merge 15 commits intotemporalio:next-serverfrom
Conversation
) <!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed <!-- Describe what has changed in this PR --> Add extended info to the DescribeWorkflow output. ## Why? <!-- Tell your future self why have you made these changes --> Customer request.
…-with-start` commands (temporalio#762) added `temporal workflow start-update-with-start` and `temporal workflow execute-update-with-start` commands `temporal workflow start-update-with-start` usage: ``` temporal workflow start-update-with-start \ --update-name YourUpdate \ --update-input '{"update-key": "update-value"}' \ --update-wait-for-stage accepted \ --workflow-id YourWorkflowId \ --type YourWorkflowType \ --task-queue YourTaskQueue \ --id-conflict-policy Fail \ --input '{"wf-key": "wf-value"}' ``` `temporal workflow execute-update-with-start` usage: ``` temporal workflow execute-update-with-start \ --update-name YourUpdate \ --update-input '{"update-key": "update-value"}' \ --workflow-id YourWorkflowId \ --type YourWorkflowType \ --task-queue YourTaskQueue \ --id-conflict-policy Fail \ --input '{"wf-key": "wf-value"}' ``` 1. Closes temporalio#664 2. How was this tested: <!--- Please describe how you tested your changes/how we can test them --> 3. Any docs updates needed? Yes
## What was changed quote attribute type in error message ## Why? To make whitespace more obvious --------- Co-authored-by: Rodrigo Zhou <2068124+rodrigozhou@users.noreply.github.com>
<!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed <!-- Describe what has changed in this PR --> Check if extended info is not nil. ## Why? <!-- Tell your future self why have you made these changes --> temporalio#771 Code assumes that some extended info exists in proto. Which is not true for older server versions..
## What was changed <!-- Describe what has changed in this PR --> Pinned v1.34.1 for modernc/sqlite ## Why? <!-- Tell your future self why have you made these changes --> 1.34.2 has a regression, waiting on https://gitlab.com/cznic/sqlite/-/issues/196 to be resolved. See temporalio/temporal#7333 for more details ## Checklist <!--- add/delete as needed ---> 1. Closes temporalio#777 2. How was this tested: <!--- Please describe how you tested your changes/how we can test them --> 3. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io -->
## What was changed
<!-- Describe what has changed in this PR -->
Added a tags section to match what Documentation side has
## Why?
<!-- Tell your future self why have you made these changes -->
We previously just used keywords, but that could be seen as keyword
stuffing. The tags were updated on the docs side a few months ago,
changes were never updated on this side.
## Checklist
<!--- add/delete as needed --->
1. Closes <!-- add issue number here -->
2. How was this tested:
<!--- Please describe how you tested your changes/how we can test them
-->
3. Any docs updates needed?
<!--- update README if applicable
or point out where to update docs.temporal.io -->
---------
Co-authored-by: Chad Retz <chad.retz@gmail.com>
## What was changed <!-- Describe what has changed in this PR --> Created a new Github Action that auto-generates and publishes a PR to the [documentation repo](https://github.com/temporalio/documentation) with the latest generated CLI docs. Corresponding docs side PR is already merged, temporalio/documentation#3525, and first PR of the auto-generated docs is merged in temporalio/documentation#3528. Docs side YML: https://github.com/temporalio/documentation/blob/main/.github/workflows/update-cli-docs.yml ## Why? <!-- Tell your future self why have you made these changes --> Makes keeping CLI docs up to date significantly easier. ## Checklist <!--- add/delete as needed ---> 1. Closes 2. How was this tested: <!--- Please describe how you tested your changes/how we can test them --> Tested in this PR, but there's a small chance I missed something in the actual release trigger workflow. No way to fully test that until a new release is cut after this action is on main. 3. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io -->
|
|
|
@maniram-yadav - did you mean to have this merged into Also, the server is not actually general purpose HTTP, it's gRPC. It's not actually a URL and we don't want to set "http" as the scheme. Most (all?) SDKs accept |
|
@cretz Also, all you people are solving very unique problem, and I am looking for some opensource contribution to you organization, let me know if I can help you or your team on backend or on frontend implementation. |
|
You will want to target If you're looking for general contribution opportunities, you may be able to ask in the |
10 participants
Cemporal cli prints prints the server url on console when server starts server start.
Url log formats are mismatching from each other. and missing http from other place in the same url.