Expose parent and root execution in describe call#781
Merged
Sushisource merged 2 commits intomainfrom Mar 25, 2025
Merged
Conversation
cretz
reviewed
Mar 25, 2025
Comment on lines
+120
to
+121
| ParentExecution *common.WorkflowExecution `cli:",cardOmitEmpty"` | ||
| RootExecution *common.WorkflowExecution `cli:",cardOmitEmpty"` |
Contributor
There was a problem hiding this comment.
I think 4 fields of ParentWorkflowId, ParentRunId, RootWorkflowId, and RootRunId would look a bit better on text output here (all being strings and having cardOmitEmpty too)
Member
Author
There was a problem hiding this comment.
Sure, I can do that. Ideally we would make it easier to recursively text-ify a struct with indents, that would be ideal, but when I've tried that before it was more work than I wanted to invest at the moment.
0b54caa to
8687ea9
Compare
cretz
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added parent/root wf info to describe
Looks like:
Why?
Checklist
Closes
[Feature Request] Expose root workflow execution #763
How was this tested:
Added test
Any docs updates needed?