Add fields from extended info to DescribeWorkflow output#771
Merged
ychebotarev merged 2 commits intomainfrom Feb 27, 2025
Merged
Add fields from extended info to DescribeWorkflow output#771ychebotarev merged 2 commits intomainfrom
ychebotarev merged 2 commits intomainfrom
Conversation
josh-berry
approved these changes
Feb 27, 2025
josh-berry
left a comment
josh-berry
left a comment
There was a problem hiding this comment.
LGTM but would like @cretz 's eyes as well
cretz
approved these changes
Feb 27, 2025
Comment on lines
+121
to
+125
| ExecutionExpirationTime time.Time | ||
| RunExpirationTime time.Time | ||
| CancelRequested bool | ||
| LastResetTime time.Time | ||
| OriginalStartTime time.Time |
Contributor
There was a problem hiding this comment.
I think we should add the cli:",cardOmitEmpty" on any of these that can have zero values, but that can be done in a subsequent PR if there are time constraints since there are no compatibility expectations with text output
ychebotarev
force-pushed
the
y_extended_info
branch
from
5b79670 to
86b0705
Compare
|
Hi @ychebotarev , version 1.3.0 panics in It looks like |
ychebotarev
added a commit
that referenced
this pull request
Mar 7, 2025
<!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed <!-- Describe what has changed in this PR --> Check if extended info is not nil. ## Why? <!-- Tell your future self why have you made these changes --> #771 Code assumes that some extended info exists in proto. Which is not true for older server versions..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add extended info to the DescribeWorkflow output.
Why?
Customer request.