Fix batch deployment test nil pointer exception#769
Merged
antlai-temporal merged 1 commit intotemporalio:mainfrom Feb 27, 2025
Merged
Fix batch deployment test nil pointer exception#769antlai-temporal merged 1 commit intotemporalio:mainfrom
antlai-temporal merged 1 commit intotemporalio:mainfrom
Conversation
josh-berry
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
TestWorkflow_Batch_Update_Options_Versioning_Overridewas assuming a complete proto responsewith versioning info, and panic with an invalid pointer ref sometimes.