Merged
Conversation
ychebotarev
requested review from
bergundy,
cretz and
josh-berry
and removed request for
josh-berry
cretz
reviewed
Feb 4, 2025
cretz
approved these changes
Feb 5, 2025
Contributor
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
Just a curious question about --match-all, nothing blocking
Comment on lines
+480
to
+484
| - name: match-all | ||
| type: bool | ||
| description: | | ||
| Every paused activity should be unpaused. This flag is ignored if | ||
| activity-type is provided. Can only be used with --query. |
Contributor
There was a problem hiding this comment.
Question, what if activity-type is not provided and this is not set either, what is the default behavior?
Contributor
Author
There was a problem hiding this comment.
This:
case BatchTypeUnpauseActivities:
if params.UnpauseActivitiesParams.ActivityType == "" && !params.UnpauseActivitiesParams.MatchAll {
return fmt.Errorf("must provide ActivityType or MatchAll flag")
}
so basically the call will fail
Contributor
There was a problem hiding this comment.
Can you make that clear in the CLI docs for users that one of these two is required when query is present? It was a bit hard to know from CLI help alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Update "activity unpause" API to support batch operation.
Why?
Part of the activity API work.
Checklist
Closes
https://temporalio.atlassian.net/browse/OSS-3789
How was this tested:
By adding test.
Not yet.