Reserve Field Tag 7 in PollWorkflowTaskQueueRequest and PollActivityTaskQueueRequest#712
Merged
VegetarianOrc merged 1 commit intomasterfrom Feb 10, 2026
Merged
Conversation
…skQueueRequest and temporal.api.workflowservice.v1.PollActivityTaskQueueRequest. Move worker_instance_key to tag 8 in those messages. Add buf ignore to allow the name worker_instance_key to be retagged.
bergundy
approved these changes
Feb 10, 2026
yuandrew
reviewed
Feb 10, 2026
Contributor
yuandrew
left a comment
yuandrew
left a comment
There was a problem hiding this comment.
LGTM, but will let Chad approve from SDK side, thanks for this fix! 🙏
cretz
approved these changes
Feb 10, 2026
Contributor
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
Approved because this (or the previous field 7) is never referred to in any SDK code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.
What changed?
Why?
This addresses a wire incompatibility between APIs version 1.50-1.54 and 1.62. Field tag 7 was removed from these messages in API version 1.55.
Breaking changes
Server PR