Skip to content

Conversation

@mrsimonemms
Copy link
Contributor

Enables the pretty colours in my IDE (and GitHub) so easier to read

@mrsimonemms mrsimonemms marked this pull request as ready for review July 30, 2025 09:41
@brendan-myers
Copy link
Collaborator

A couple reasons why this wasn't named config.yaml;

  • config.yaml is the default filename the proxy looks for, so this might be confusing if someone tries to build/run without realising they need to provide a valid config.
  • helps avoid accidentally committing an actual config to github.

We could rename it config.sample.yaml which would enable pretty colours and still avoid the issues above. Thoughts?

@mrsimonemms
Copy link
Contributor Author

Yeah, naming is config.sample.yaml is what I've done, isn't it? (I'm now doubting my ability to read 😄)

image

@brendan-myers
Copy link
Collaborator

Well this is embarrassing for me 🤦‍♂️ On the bright side, at least even with my lack of reading comprehension I still managed to come to the same conclusion!

@brendan-myers brendan-myers merged commit d17156d into temporal-sa:main Jul 31, 2025
1 check passed
@mrsimonemms mrsimonemms deleted the sje/config-yaml-rename branch July 31, 2025 08:44
@mrsimonemms
Copy link
Contributor Author

Don't fret it mate. Your awesomity has to come with human frailties else the rest of us couldn't keep up ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants