-
Notifications
You must be signed in to change notification settings - Fork 10
Get available levels; Getters and Setters for types on actors & static meshes #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jasonashton
wants to merge
11
commits into
tempo-sim:main
Choose a base branch
from
aurum-ai:jashton/get-set-static-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7d57182
First attempt at actor re-labeling
jasonashton 6d6cf9a
Add Set Component Semantic Id
jasonashton 5142ba1
Change class id for actor types, not individual actors
jasonashton e55efee
Add Actors Near Position RPC
jasonashton 6b553a8
add rpc to get available levels
jasonashton 7ef9a6a
Get and Set static mesh semantic IDs
jasonashton fe0da5e
cleanup
jasonashton 110515f
Runtime pointer fix
jasonashton 4506865
low memory package option
jasonashton e91a1c7
Evict frame when falling behind
jasonashton 8702754
Pass FInstanceSemanticIdPair by value to prevent segfault
jasonashton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really just gets any assets at a path. Not sure if we should add more filtering to truly get all levels or make it a more generic RPC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean I think this RPC would be very useful but it shouldn't have a name specific to levels. We could have both and they could share a helper. Is it possible to find only levels? Does the umap extension help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can make it a more generic RPC, it does look like there's a way to filter by levels and add a more specific RPC, or we can filter client side maybe by .umap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think two RPCs, one for levels and one for all non-level assets would be best. I don't really think of levels as "assets"