feat(core): enable partial discovery by default during development #1848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innocenzi
force-pushed
the
feat/partial-discovery-by-default
branch
from
d0d642c to
9f49785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables partial discovery by default during development, and updates the discovery documentation with more information and a troubleshooting section.
I think that with the default
post-package-updatescript that we provide, and given that we recommend setting it in the documentation, this is a safe thing to do. I also documented that when working on packages in a local environment, the discovery cache should manually be disabled.I also added tests for the strategy initialization and shared the logic between the discovery cache initializer and the
discovery:generatecommand.Closes #1845