Open
Conversation
Contributor
Author
|
There are two workarounds for this issue:
But IMO, the perfect solution may be to support buffering: tempesta-tech/tempesta#498 I think it also fixes #1715. |
RomanBelozerov
requested changes
May 13, 2024
bef5eab to
7e98c74
Compare
Contributor
|
@kingluo @krizhanovsky @const-t We should not use
I think we should wait for #498 issue or make a temporary workaround. |
6 tasks
d3f7ce4 to
f484e7e
Compare
- update tests_retry, some frang tests are unstable yet;
c28e670 to
36e9d6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #612
CVE-2019-9511 “Data Dribble”
CVE-2019-9517 “Internal Data Buffering”
Both attacks accumulate big responses from the backend which causes OOM.
The strange thing is,keepalive_timeoutdoes not help, it does not reset or fin the TCP connection. For example, in “Internal Data Buffering”, the keepalive timer only stops the TCP retransmits from tempesta but does not reset the connection. I need to look into this more.