Closed
Conversation
kingluo
force-pushed
the
jinhua/fix-1346-flood
branch
from
4d93c65 to
63e2a8c
Compare
RomanBelozerov
requested changes
May 9, 2024
Contributor
|
and you need to add these tests to |
- they are no stress tests anymore, now they are tests for `max_queued_control_frames` directive. We don't need a stress tests because TempestaFW has ways to protect against such an attack; - all tests work on DeproxyClientH2; - add tests for default and other values;
…p2_general/test_max_queued_control_frames.py`
change expected number of dmesg warnings. TempestaFW doesn't always output a warning in dmesg
RomanBelozerov
approved these changes
May 28, 2024
RomanBelozerov
force-pushed
the
jinhua/fix-1346-flood
branch
from
69fef44 to
1e3e12e
Compare
kingluo
commented
Jun 3, 2024
| client.send_bytes(client.h2_connection.data_to_send()) | ||
| self.assertTrue(client.wait_for_ack_settings()) | ||
|
|
||
| client.make_request(client.create_request(method="GET", headers=[])) |
Contributor
Author
There was a problem hiding this comment.
There is no need to request a large response now, because the sockbuf is already set to a small enough size. Also we don't need the backend, because control-frame-slow-read does not involve the backend.
RomanBelozerov
force-pushed
the
jinhua/fix-1346-flood
branch
2 times, most recently
from
fb27281 to
11076fe
Compare
RomanBelozerov
force-pushed
the
jinhua/fix-1346-flood
branch
from
11076fe to
fcd22dc
Compare
6 tasks
| }, | ||
| { | ||
| "name": "t_stress.test_flood.TestH2ControlFramesFlood.test_reset_stream", | ||
| "reason": "Disabled by test issue #612" |
Contributor
There was a problem hiding this comment.
Please comment test cases with CVE number and name of attack that we can easily grep test suite for the attack scenarios. Even better to name the tests according to the emulated attacks.
Contributor
|
Closed. Added the same tests using GO in #729 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #612
tests for tempesta-tech/tempesta#2108