Add support for authentication as a GitHub App #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for authentication as a GitHub App. This is beneficial in several ways, including: * Increased rate limits * Better separation of access * Finer grained control over access * Removes the need for a bot or service account As part of these changes, have added the `github.com/bradleyfalzon/ghinstallation/v2` module and it's associated dependencies. Added several new configuration fields: * `UseGitHubApp` - Boolean flag signalling if user wants to auth as a GitHub App * `PrivateKeyFile` - Filename for RSA Private Key generated for GitHub App * `AppID` - GitHub App application numerical identifier * `InstallationID` - GitHub App installation numerical identifier
This enables either reading the private key from a file, or providing the contents of the private key. Expanded testing to cover additional scenarios. Also rename `AppID` to `ApplicationID`.
|
Any updates on when this can be merged? Would love to use Github App as an authentication to take advantage of the 15,000 requests per hour (rate limit). |
|
love, nice work will try to get this merged in this fork https://github.com/cloudfoundry-community/github-pr-instances-resource or we will need a new fork that has this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for authentication as a GitHub App.
This is beneficial in several ways, including:
As part of these changes, have added the
github.com/bradleyfalzon/ghinstallation/v2module and it's associated dependencies.
Added several new configuration fields:
UseGitHubApp- Boolean flag signalling if user wants to auth as a GitHub AppPrivateKey- PEM encoded private keyPrivateKeyFile- Filename for RSA Private Key generated for GitHub AppAppID- GitHub App application numerical identifierInstallationID- GitHub App installation numerical identifierN.B I'm currently working on documentation and integration testing, however I thought it would be useful to get early feedback...