Skip to content

Add Preview Support for GHE endpoints #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rickardl wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add Preview Support for GHE endpoints #239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0354a8
add-preview-support-ghe
rickardl Oct 22, 2020
1a69570
simplify draft example
rickardl Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,32 @@ type GithubClient struct {
Owner string
}

type withPreviewHeader struct {
http.Header
rt http.RoundTripper
previewHeaders []string
}

func WithPreviewHeader(rt http.RoundTripper, previewHeaders []string) withPreviewHeader {
if rt == nil {
rt = http.DefaultTransport
}

headers := make(http.Header)
return withPreviewHeader{Header: headers, rt: rt, previewHeaders: previewHeaders}
}

func (h withPreviewHeader) RoundTrip(req *http.Request) (*http.Response, error) {
for k, v := range h.Header {
req.Header[k] = v
}

currentAccept := req.Header.Get("Accept")
// shadow-cat-preview: Draft pull requests
req.Header.Set("Accept", fmt.Sprintf("%s,%s", currentAccept, strings.Join(h.previewHeaders, ",")))
return h.rt.RoundTrip(req)
}

// NewGithubClient ...
func NewGithubClient(s *Source) (*GithubClient, error) {
owner, repository, err := parseRepository(s.Repository)
Expand All @@ -47,6 +73,9 @@ func NewGithubClient(s *Source) (*GithubClient, error) {
// Skip SSL verification for self-signed certificates
// source: https://github.com/google/go-github/pull/598#issuecomment-333039238
var ctx context.Context

// Support Enterprise Server

if s.SkipSSLVerification {
insecureClient := &http.Client{Transport: &http.Transport{
TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
Expand Down Expand Up @@ -81,6 +110,9 @@ func NewGithubClient(s *Source) (*GithubClient, error) {
if err != nil {
return nil, fmt.Errorf("failed to parse v4 endpoint: %s", err)
}
previewV4Headers := []string{"application/vnd.github.antiope-preview+json", "application/vnd.github.shadow-cat-preview+json", "application/vnd.github.bane-preview+json"}
rt := WithPreviewHeader(client.Transport, previewV4Headers)
client.Transport = rt
v4 = githubv4.NewEnterpriseClient(endpoint.String(), client)
if err != nil {
return nil, err
Expand Down