Skip to content

utf-8 encoding fix (for 3.8) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5shekel wants to merge 1 commit into
base: yair/errata
Choose a base branch
from
Open

utf-8 encoding fix (for 3.8) #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions bank2invoice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ def main(xl_file, conf):

existing = get_existing_documents(default_doctype) # needed to prevent duplicates

s = open(xl_file).read()
s = open(xl_file, encoding='utf-8').read()
s = normalize_dates(s) # convert israeli (european) dates to ISO dates
# green-invoice requires them,
# plus we must sort by date.
Expand Down Expand Up @@ -392,15 +392,20 @@ def self_test():
18/12/2026 גגג גגיגיג 20 567 987654 333.00 תאריך חדש מדי
18/12/2021 גגג גגגיג 34 567 987654 222.00 תאריך ישן מדי
'''
open(f,'w').write(test_data)
open(f,'w',encoding='utf-8').write(test_data)
main(f, conf)


conf = read_conf()
if f'{sys.version_info.major:02d}{sys.version_info.minor:02d}' < '0310':
msg = f'WARNING !!! '*5 + f'\n "bank2invoice.py" was tested on python 3.10, not on {sys.version_info.major}.{sys.version_info.minor}.'
# check for known version and operating system
if sys.version_info >= (3, 8) or sys.version_info <= (3, 9):
print("This script is good on Python 3.8.x.")
elif f'{sys.version_info.major:02d}{sys.version_info.minor:02d}' > '0310':
msg = '"bank2invoice.py" was tested on python 3.10, you are using python ' + sys.version
if sys.platform == 'win32':
msg += f'\nAs a Windows user, follow "Windows Note:" in the install section of readme\n\n'
print(msg)
err(msg)
Warning(msg)



Expand Down
1 change: 1 addition & 0 deletions bank2invoice.sample.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ email=blabla@gmail.com
api_key_id=blablabla-blablabla-blablabla
api_key_secret=junk11-random1-shit11-stuff1
currency=ILS
sandbox_api_url=https://api.greeninvoice.co.il/api/v1/
sanbox_api_id=dfkgjhsdkfjshfksjhskljfs
sandbox_api_secret=kdjfhszkjdsznkljdskszn