Skip to content

Conversation

@mbpavan
Copy link
Contributor

@mbpavan mbpavan commented Dec 16, 2025

Changes

Multi arch builds are failing with the below error.
go: github.com/google/ko@latest: github.com/google/ko@v0.18.1 requires go >= 1.25.0 (running go 1.24.1; GOTOOLCHAIN=local)

hence adding ko version explicitly

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Dec 16, 2025
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 16, 2025
@mbpavan
Copy link
Contributor Author

mbpavan commented Dec 16, 2025

/retest

@jkhelil
Copy link
Member

jkhelil commented Dec 16, 2025

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2025
@anithapriyanatarajan
Copy link
Contributor

anithapriyanatarajan commented Dec 16, 2025

@mbpavan Instead of pinning the version of ko can we update the ci workflow to use the installed ko version - by replacing https://github.com/tektoncd/operator/blob/main/.github/workflows/ci.yaml#L144-L145 with

  # Kubernetes
  KO_DOCKER_REPO=example.com \
  kustomize build --load-restrictor LoadRestrictionsNone config/kubernetes/overlays/default | \
  ko resolve --push=false --platform=all \
    --oci-layout-path=.bin/oci -f -

  # OpenShift
  KO_DOCKER_REPO=example.com \
  kustomize build --load-restrictor LoadRestrictionsNone config/openshift/overlays/default | \
  ko resolve --push=false --platform=all \
    --oci-layout-path=.bin/oci -f -
    
This way we do not fix the ko version to an older version. The the ci workflow uses the version of ko installed in the previous step rather than building one more time?

@jkhelil
Copy link
Member

jkhelil commented Dec 16, 2025

/approve cancel

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from mbpavan after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2025
@anithapriyanatarajan
Copy link
Contributor

@mbpavan @jkhelil - Thanks for the discussion. I shall mark this PR on hold. In any case we need to fix the make file so that make apply for contributors works smooth while the CI will be fixed with a separate PR that decouples ci workflow from leveraging the make resolve

@anithapriyanatarajan
Copy link
Contributor

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants