Change count stat variable type from int to long #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pthirun
force-pushed
the
pthiruna/fix-count-overflow
branch
from
9cb28a2 to
1f6e2bb
Compare
pthirun
force-pushed
the
pthiruna/fix-count-overflow
branch
from
1f6e2bb to
74be72a
Compare
pthirun
changed the title
m-nagarajan
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The metric using the
Countstat will suffer from integer overflow in high traffic environments. This will cause the metric to emit negative values.Solution:
Change the metric type to a
Long.