Various changes that will handle some of the open issues#19
Merged
tehlers merged 4 commits intotehlers:masterfrom May 25, 2025
Merged
Various changes that will handle some of the open issues#19tehlers merged 4 commits intotehlers:masterfrom
tehlers merged 4 commits intotehlers:masterfrom
Conversation
Replaced the deprecated JCenter repository with MavenCentral, ensuring continued access to dependencies. Fixed syntax inconsistency in the "check" task dependency for better readability and adherence to Gradle conventions.
Replaced all occurrences of `testJarsPath()` with `jarsPath()` for consistency and improved readability. Updated method declarations and corresponding calls to align with this change.
Updated task creation logic to use `tasks.register` with `TaskProvider` API for better laziness and performance. Shifted `dependsOn` configuration into an `afterEvaluate` block to ensure proper task dependencies. This improves compatibility with modern Gradle versions.
Converted mutable fields to final where applicable for increased immutability and readability. Replaced `GradleException` usage with logging for missing/invalid ZIP files, enhancing error handling. Streamlined and modernized code constructs, including lambda expressions and method references, and updated configurations for better compatibility.
Owner
|
Thanks 👍 |
This was referenced May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
non-zip artifacts are properly handled and don't crash the check process anymore. Log warning message instead
Log warning instead of throwing an exception if the artifact that has to be checked can't be found on the file system.
Change how the task is registered and attached to the check task.
Change the functional test to verify that plugin task is properly attached to the check task
Use project.layout instead of project.buildDir.