Add namespace support for rendering widgets#120
Open
beckyresler wants to merge 1 commit intoteepluss:masterfrom
Open
Add namespace support for rendering widgets#120beckyresler wants to merge 1 commit intoteepluss:masterfrom
beckyresler wants to merge 1 commit intoteepluss:masterfrom
Conversation
modified function widget(): - added a 3rd optional parameter to the function call, ; defaults to null - added code to use the specified namespace, if set, when setting $className; otherwise uses the widget namespace from the theme config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a situation where I need to be able to render a widget that is part of another package, i.e. it is outside of the App\Widgets namespace. (see #119)
I modified the Theme::widget() call to have an optional 3rd parameter for the namespace, which defaults to null.