Fix inconsistent paths #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorplewe
reviewed
Aug 10, 2025
Comment on lines
+18
to
+24
| UriMode::VSCode => { | ||
| let drive = format!("{}:", drive_letter.to_ascii_lowercase()); | ||
| encode(&drive).to_string() | ||
| } | ||
| UriMode::Helix => { | ||
| format!("{}:", drive_letter.to_ascii_uppercase()) | ||
| } |
Collaborator
There was a problem hiding this comment.
So VSCode does NOT allow C: and helix does NOT allow c:? do we know about neovim and zed?
Owner
Author
There was a problem hiding this comment.
Not entirely sure about those two, but they should fall into one of the two categories.
Collaborator
There was a problem hiding this comment.
I'll approve and we'll see. Neither of us daily drive those so shouldn't be a problem yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.