-
Notifications
You must be signed in to change notification settings - Fork 5
Contribution of ConTeXTMatch model #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution of ConTeXTMatch model #18
Conversation
|
Great contribution Warre! First 5-ish commits are still changes from the previous addition to evaluate multiple models.
Second thing we'd like to check, to make sure the implementation of ContextMatch is correct, could we give it a shot on SkillExtract Tech (smallest)? Then we can see if it reproduces the original results in the paper. |
|
I have indeed branched my new addition from my previous one, as this was still the most up to date version. Both comments are very valid, and I'll make sure to (1) contribute in a standard way and (2) also check with the paper results. |
0ca1f6a to
fa82991
Compare
Mattdl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great functional test. LGTM
Description
Checklist