Skip to content

[BUG FIX] wrong order attributes evaluate call in evaluate_multiple_models function #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mattdl merged 6 commits into from
Dec 10, 2025
Merged

[BUG FIX] wrong order attributes evaluate call in evaluate_multiple_models function #17

Mattdl merged 6 commits into from
Dec 10, 2025

Conversation

@warreveys
Copy link
Contributor

@warreveys warreveys commented Dec 10, 2025

evaluate_multiple_models passed arguments to evaluate in the wrong order: tasks was passed as model and model was passed as tasks.

@Mattdl
Copy link
Collaborator

Mattdl commented Dec 10, 2025

Thanks for your first PR to WorkRB, Warre! And great catch.

To avoid future issues with this method, would it also be possible to add a test for the evaluate_multiple_models call? It could contain a mock task just to make sure the method works as expected. LMK if you're up for it or would like me to have a look at it.

@Mattdl Mattdl requested review from Mattdl and removed request for Mattdl December 10, 2025 09:38
@Mattdl Mattdl marked this pull request as draft December 10, 2025 09:59
@warreveys warreveys marked this pull request as ready for review December 10, 2025 10:52
@Mattdl Mattdl self-requested a review December 10, 2025 10:53
Mattdl
Mattdl reviewed Dec 10, 2025
View reviewed changes
Copy link
Collaborator

@Mattdl Mattdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See in-line comments.

Mattdl
Mattdl approved these changes Dec 10, 2025
View reviewed changes
Copy link
Collaborator

@Mattdl Mattdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge! (:

@Mattdl Mattdl merged commit 149acb6 into techwolf-ai:main Dec 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mattdl Mattdl Mattdl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@warreveys @Mattdl