Saving of state field on edit of ucm item form#255
Open
shraddhaSankpal27 wants to merge 4 commits intotechjoomla:release-1.2.4from
Open
Saving of state field on edit of ucm item form#255shraddhaSankpal27 wants to merge 4 commits intotechjoomla:release-1.2.4from
shraddhaSankpal27 wants to merge 4 commits intotechjoomla:release-1.2.4from
Conversation
added 2 commits
November 25, 2019 18:45
Contributor
|
As per requirement code is ok |
added 2 commits
December 4, 2019 17:17
Collaborator
|
@shraddhaSankpal27 Please add a description to the MR, it's not clear why exactly we have updated the code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-As user I can able to edit state value from itemform view. For that only need to update in saveFormData() method.
-Editing item state field from itemform view, override itemform view and remove hidden state field and add single select for state field.