feat(postgres): modify the docker base image as postgres:11-alpine#5
Merged
Cryptophobia merged 8 commits intoteamhephy:masterfrom Nov 28, 2018
Merged
feat(postgres): modify the docker base image as postgres:11-alpine#5Cryptophobia merged 8 commits intoteamhephy:masterfrom
Cryptophobia merged 8 commits intoteamhephy:masterfrom
Conversation
duanhongyi
changed the title
duanhongyi
force-pushed
the
master
branch
3 times, most recently
from
1d1d8a0 to
e1b0c3b
Compare
Member
|
Looks good! It's exciting that it's only 1/3 the size of the original postgres image. @duanhongyi , is this ready for review and merge? |
Member
Author
yes |
till
suggested changes
Nov 19, 2018
till
left a comment
till
left a comment
There was a problem hiding this comment.
Mostly a few questions.
Nice work! The size improvement will be significant!
till
reviewed
Nov 19, 2018
till
approved these changes
Nov 19, 2018
till
left a comment
till
left a comment
There was a problem hiding this comment.
Thanks for responding to all my questions.
Good to merge, IMO!
This was referenced Nov 24, 2018
duanhongyi
force-pushed
the
master
branch
3 times, most recently
from
34e3648 to
ea21ee1
Compare
Member
Author
|
close, see #7 |
Member
|
@duanhongyi , I'm going to reopen merge this PR as it has better history for the approval process. |
Member
|
Merging this in now and going to build a new tag v2.7.1 so we can make Hephy Workflow v2.20 start up faster @kingdonb @duanhongyi 😁 |
|
Yay!!! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using postgres:11-alpine instead of the postgres:11, the size is close to the original 1/3.