Skip to content

Conversation

@chuan6
Copy link
Contributor

@chuan6 chuan6 commented Jul 29, 2019

...err 是 Observable 的合理可能只存在于有地方抛错时抛的是 Observable
的情况;这不符合正常操作习惯。(已经在 #668 中由于导致测试失败提前调整)

  • 确认当前 persist 方法里可能遇到的报错对象有哪些?
  • 补充单元测试

...err 是 Observable 的合理可能只存在于有地方抛错时抛的是 Observable
的情况;这不符合正常操作习惯。
@chuan6 chuan6 added the bug label Jul 29, 2019
@chuan6 chuan6 requested a review from 2eha0 July 29, 2019 10:21
@chuan6 chuan6 self-assigned this Jul 29, 2019
@chuan6
Copy link
Contributor Author

chuan6 commented Jul 29, 2019

@2eha0 这个修正我还没处理完,等上面两个 todo 里的东西处理好了,我找你帮忙 review 一下哈,谢谢 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants