spent way to long to make this pr bruh #10
Conversation
00magikarp
left a comment
00magikarp
left a comment
There was a problem hiding this comment.
just wanna say that for ur first subsystem this is exceptional code. many of my comments are just nitpicks 😭 but overall the structure and logic looks amazing, gj 😸
ofc... theres work to be done 😼 lock in and get this cleaned up
src/main/kotlin/com/team4099/robot2025/config/constants/IntakeConstants.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/team4099/robot2025/config/constants/IntakeConstants.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/team4099/robot2025/subsystems/intake/Intake.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/team4099/robot2025/subsystems/intake/Intake.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/team4099/robot2025/subsystems/intake/IntakeIOSim.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/team4099/robot2025/subsystems/intake/IntakeIOTalonFX.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/team4099/robot2025/subsystems/intake/IntakeIOTalonFX.kt
Show resolved
Hide resolved
src/main/kotlin/com/team4099/robot2025/subsystems/intake/IntakeTunableValues.kt
Show resolved
Hide resolved
src/main/kotlin/com/team4099/robot2025/subsystems/superstructure/Request.kt
Outdated
Show resolved
Hide resolved
|
^^ do not merge to main ofc |
00magikarp
left a comment
00magikarp
left a comment
There was a problem hiding this comment.
better -- a lot better
remove the unneccessary edits, especially to files not related to intake. (if spotlessapply did that its fine)
very good job on getting comments resolved so quickly 😄
src/main/kotlin/com/team4099/robot2025/subsystems/intake/Intake.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/team4099/robot2025/subsystems/intake/IntakeTunableValues.kt
Outdated
Show resolved
Hide resolved
|
|
||
| class ClosedLoop(val position: Angle) : IntakeRequest | ||
|
|
||
| class Uninitialized(): IntakeRequest |
There was a problem hiding this comment.
wait you need a closed loop, and uninitialized state right?
There was a problem hiding this comment.
interesting, shayaan's has "targeting_pos" as a state instead, which makes more sense ig, wb uninitialized?
There was a problem hiding this comment.
you need an unitialized state, but not a request. you never request to be uninitialized
1st subsystem code! pls be harsh