[feat/#58] 사용자 문항/새끼문항 제출, 통계 도메인 설계 및 구현#80
Merged
seokbeom00 merged 7 commits intodevelopfrom Mar 11, 2025
Merged
Conversation
sejoon00
reviewed
Mar 2, 2025
| private Long id; | ||
|
|
||
| @Column(name = "member_statistics_id", nullable = false) | ||
| private Long memberStatisticsId; |
Contributor
There was a problem hiding this comment.
사용자 통계와 틀린 개념 통계, 맞은 개념 통계의 연관 관계에서 다대일보다는 일대다가 더 적합한 경우일 수 있다는 생각이 드네요.
각 개별 통계는 사용자 통계를 알 필요가 없지만, 사용자 통계는 루트 엔티티로서 통계를 취합하고 계산하는 책임을 가지고 있습니다.
그래서 각 통계를 List로 가지고 있다면, 사용자 통계에서 이들을 관리하고, 계산하는 데 훨씬 용이할 것 같다는 생각입니다.
|
|
||
| @Column(name = "problem_set_id", nullable = false) | ||
| private Long problemSetId; | ||
|
|
Contributor
There was a problem hiding this comment.
진척도가 추가되면 좋을 것 같습니다.
SetSubmit에서 하위 문제들을 몇 번까지 풀었는지 진척도를 계산할 수 있는 비즈니스로직도 추가되면 좋을 것 같아요
Contributor
Author
There was a problem hiding this comment.
진척도는 추후, 조회 API 구현 시 Dto필드에 추가하겠습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Issue
📄 Description
📌 도메인 설계 변경 사항
문항제출 & 새끼문항제출
사용자 통계
📌 추후 고려 사항