Skip to content

[Refactor] 온보딩 OCR에서 국가 반환 형태 LocalizedItemResponse로 수정 #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeong1112 merged 2 commits into from
Apr 10, 2026
Merged

[Refactor] 온보딩 OCR에서 국가 반환 형태 LocalizedItemResponse로 수정 #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
814e24f
[Refactor] #235 온보딩/약관동의 조회 로직에서 memberVisa 조회 로직 제거
jeong1112 Apr 10, 2026
1046908
[Refactor] #235 여권 OCR 국가 응답 LocalizedItemResponse로 변경
jeong1112 Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/main/java/org/sopt/kareer/domain/member/dto/response/OcrPassportResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,17 @@ public record OcrPassportResponse(
@Schema(description = "Full Name", example = "Hong Seungwon")
String fullName,

@Schema(description = "국가", example = "AFGHANISTAN")
Country country,
@Schema(description = "국가 코드 및 라벨", example = "{\"code\": \"south-korea\", \"label\": \"South Korea\"}")
LocalizedItemResponse country,

@Schema(description = "생년월일")
LocalDate birthDate
) {
public static OcrPassportResponse from(PassportOcrParser.PassportInfo passportInfo) {
Country country = passportInfo.country();
return OcrPassportResponse.builder()
.fullName(passportInfo.fullName())
.country(passportInfo.country())
.country(country != null ? new LocalizedItemResponse(country.getCode(), country.getCountryName()) : null)
.birthDate(passportInfo.birthDate())
.build();
}
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/org/sopt/kareer/domain/member/entity/enums/Country.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,10 @@ public enum Country {
country -> country.countryName.toLowerCase(),
Function.identity()));

public String getCode() {
return name().toLowerCase().replace("_", "-");
}

public static List<String> getCountries() {
return Arrays.stream(Country.values())
.map(Country::getCountryName)
Expand Down
3 changes: 0 additions & 3 deletions src/main/java/org/sopt/kareer/domain/member/service/MemberService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,9 +310,6 @@ public void agreeTerms(Long memberId, MemberTermsRequest request) {
public MemberCompletionResponse getCompletion(Long memberId){
Member member = getById(memberId);

MemberVisa memberVisa = memberVisaRepository.findActiveByMemberId(memberId)
.orElseThrow(() -> new MemberException(MemberErrorCode.VISA_NOT_FOUND));

boolean onboardingRequired = member.getStatus().equals(MemberStatus.PENDING);
boolean agreedTerm = memberTermRepository.existsByMemberIdAndAgreedTrue(memberId);

Expand Down
Loading