Skip to content

[Feat] X-Preferred-Language 헤더 CORS 문제 해결#217

Merged
eraser502 merged 1 commit intodevelopfrom
feat/#216-cors
Mar 27, 2026
Merged

[Feat] X-Preferred-Language 헤더 CORS 문제 해결#217
eraser502 merged 1 commit intodevelopfrom
feat/#216-cors

Conversation

@eraser502
Copy link
Copy Markdown
Collaborator

@eraser502 eraser502 commented Mar 27, 2026

Related issue 🛠

Work Description 📝

  • 다국어 처리 구조를 위해 X-Preferred-Language 추가했었는데 해당 부분을 CORS 허용 헤더에 추가하지 않아서 클라이언트 측에서 오류가 발생했어요.
  • 따라서 CORS 허용 헤더에 X-Preferred-Language를 추가하는 작업을 진행했어요.

ScreenShots 📷

To Reviewers 📢

Summary by CodeRabbit

릴리스 노트

  • 기술 개선
    • 언어 선호도 설정을 더욱 안정적으로 처리할 수 있도록 요청 헤더 구성을 확대했습니다.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a1351631-34f0-4064-be11-4c89ca7ca9ef

📥 Commits

Reviewing files that changed from the base of the PR and between 3de04b4 and ba2afea.

📒 Files selected for processing (1)
  • src/main/java/org/sopt/kareer/global/config/security/CorsConfig.java

📝 Walkthrough

Walkthrough

CORS 설정에서 X-Preferred-Language 요청 헤더를 허용된 헤더 목록에 추가하여 언어 선호도 헤더의 CORS 검증 문제를 해결했습니다.

Changes

Cohort / File(s) Summary
CORS 헤더 설정
src/main/java/org/sopt/kareer/global/config/security/CorsConfig.java
허용된 요청 헤더 목록에 X-Preferred-Language 헤더 추가

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • hyomee2
  • jeong1112

Poem

🐰 한 줄의 변화로 헤더는 통과,
언어 선호도는 이제 CORS를 거쳐,
작지만 소중한 설정의 손길이,
전 세계 사용자를 반기네! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목은 X-Preferred-Language 헤더를 CORS 설정에 추가하는 변경사항을 명확하게 설명하며, 파일 변경사항과 일치합니다.
Linked Issues check ✅ Passed PR의 코드 변경사항이 연결된 #216 이슈의 목표인 CORS 허용 헤더에 X-Preferred-Language를 추가하는 요구사항을 충족합니다.
Out of Scope Changes check ✅ Passed 모든 코드 변경사항이 #216 이슈의 범위 내에서 CORS 설정 업데이트에만 집중하며, 범위를 벗어난 변경사항이 없습니다.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/#216-cors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eraser502 eraser502 merged commit 859efe4 into develop Mar 27, 2026
2 checks passed
@eraser502 eraser502 deleted the feat/#216-cors branch March 27, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] X-Preferred-Language 헤더 CORS 문제 해결

2 participants