-
Notifications
You must be signed in to change notification settings - Fork 1
[Feat] 다국어 처리 구조 구현 #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 다국어 처리 구조 구현 #212
Changes from all commits
9d3bffd
fdeabe0
abd39a8
cf8fb3d
644ee44
91f7b43
f3dd06c
f7c50ea
fc9ffd9
e97bf2f
0f21276
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,20 +19,20 @@ public record MypageRequest( | |
| LocalDate birthDate, | ||
|
|
||
| @Schema(description = "국가", example = "Afghanistan") | ||
| @NotNull(message = "국가는 필수 입력값입니다.") | ||
| Country country, | ||
| @NotNull(message = "국가코드는 필수 입력값입니다.") | ||
| String countryCode, | ||
|
|
||
| @Schema(description = "학위", example = "DOMESTIC_ASSOCIATE") | ||
| @NotNull(message = "학위는 필수 입력값입니다.") | ||
| Degree degree, | ||
|
|
||
| @Schema(description = "대학", example = "Konkuk University") | ||
| @NotBlank(message = "대학은 필수 입력값입니다.") | ||
| String university, | ||
| @NotBlank(message = "대학코드는 필수 입력값입니다.") | ||
| String universityCode, | ||
|
|
||
| @Schema(description = "전공", example = "Computer Science") | ||
| @NotBlank(message = "전공은 필수 입력값입니다.") | ||
| String primaryMajor, | ||
| @NotBlank(message = "전공코드는 필수 입력값입니다.") | ||
| String primaryMajorCode, | ||
|
Comment on lines
+22
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: find . -type f -name "MypageRequest.java" | head -5Repository: team-kareer/kareer-server Length of output: 145 🏁 Script executed: cat -n src/main/java/org/sopt/kareer/domain/member/dto/request/MypageRequest.java | head -50Repository: team-kareer/kareer-server Length of output: 2152 코드형 요청 계약을 일관되게 맞춰 주세요.
🧩 수정 예시- `@Schema`(description = "국가", example = "Afghanistan")
- `@NotNull`(message = "국가코드는 필수 입력값입니다.")
+ `@Schema`(description = "국가 코드", example = "afghanistan")
+ `@NotBlank`(message = "국가코드는 필수 입력값입니다.")
String countryCode,
@@
- `@Schema`(description = "대학", example = "Konkuk University")
+ `@Schema`(description = "대학 코드", example = "konkuk-university")
`@NotBlank`(message = "대학코드는 필수 입력값입니다.")
String universityCode,
@@
- `@Schema`(description = "전공", example = "Computer Science")
+ `@Schema`(description = "전공 코드", example = "computer-science")
`@NotBlank`(message = "전공코드는 필수 입력값입니다.")
String primaryMajorCode,🤖 Prompt for AI Agents |
||
|
|
||
| @Schema(description = "부전공", example = "Statistic") | ||
| @NotBlank(message = "부전공은 필수 입력값입니다.") | ||
|
|
@@ -55,8 +55,8 @@ public record MypageRequest( | |
| EnglishLevel englishLevel | ||
| ) { | ||
| public MypageCommand toCommand(){ | ||
| return new MypageCommand(this.targetJob, this.birthDate, this.country, | ||
| this.degree, this.university, this.primaryMajor, this.secondaryMajor, this.visaType, | ||
| return new MypageCommand(this.targetJob, this.birthDate, this.countryCode, | ||
| this.degree, this.universityCode, this.primaryMajorCode, this.secondaryMajor, this.visaType, | ||
| this.visaExpiredAt, this.languageLevel, this.englishLevel); | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| package org.sopt.kareer.domain.member.dto.response; | ||
|
|
||
| public record LocalizedItemResponse(String code, String label) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: team-kareer/kareer-server
Length of output: 2327
🏁 Script executed:
Repository: team-kareer/kareer-server
Length of output: 4773
🏁 Script executed:
Repository: team-kareer/kareer-server
Length of output: 3237
코드 문자열은
@NotBlank로 검증해야 합니다.universityCode와countryCode가String인데@NotNull만 사용하고 있어서""또는 공백 문자열이 통과합니다. 같은 레코드의 다른 코드 필드들(primaryMajorCode,name,targetJob)은 모두@NotBlank를 사용하고 있습니다. 이 두 필드는 이후 라벨 조회 키로 사용되므로 빈 값이 저장되면 매핑이 깨집니다.수정 예시
📝 Committable suggestion
🤖 Prompt for AI Agents