Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Jsplix
reviewed
Aug 31, 2025
Contributor
Jsplix
left a comment
Jsplix
left a comment
There was a problem hiding this comment.
고생하셨습니다~ 코멘트 확인부탁드립니다. ㅎㅎ
soooheeee
commented
Sep 8, 2025
| const accessToken = getStoredToken(); | ||
| const trimmedValues = inputValues.map((value) => value.trim()); | ||
|
|
||
| const hasEmpty = trimmedValues.some((v) => v.length === 0); |
Contributor
Author
There was a problem hiding this comment.
추가적으로 공백만 입력하면 trim()으로 잘려서 ""가 되고, v.length === 0이 되어 hasEmpty가 true가 됩니다. 이 과정으로 alert창이 뜨도록 구현했습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Login,Logout버튼을 아이콘으로 수정하기 위함Problem Solving
로그인/로그아웃 버튼을 아이콘으로 변경
(commit: 56ae2ff)
비밀번호 설정 시:
경고 메시지가 버튼과 겹치는 문제 수정
(5126bd2)
입력값을 모두 삭제해도 경고 메시지가 남아있는 문제 수정
(5126bd2)
공백 입력 시 경고 문구 표시 및 버튼 활성화(c7dff38)
Refactor(HK-163): 세부부분 수정 #71 (comment)
코드 리뷰 반영 전코드 리뷰 반영 후To Reviewer
코드 리뷰 반영해서 다시 올렸습니다~
확인해 주세요!