-
-
Notifications
You must be signed in to change notification settings - Fork 8
social lexicons #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
social lexicons #63
Conversation
espeon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good start! making teal more social is definitely a plus tbh
packages/lexicons/real/fm/teal/alpha/feed/social/playlistItem.json
Outdated
Show resolved
Hide resolved
- lexicon stolen from place.stream.richtext.facet lol
espeon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good 👍🏼
Deploying amethyst with
|
| Latest commit: |
bd4858d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://89e28f91.teal-ao8.pages.dev |
| Branch Preview URL: | https://social-lexicons.teal-ao8.pages.dev |
espeon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good so far, but there are some compilation issues that should prolly be fixed before we merge.
|
actually huh, i don't think changes here are causing the compilation issues. will look into this tonight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces social interaction lexicons for the Teal.fm platform, implementing core social features for music sharing and engagement. The changes add support for posts, likes, reposts, playlists, and playlist items within the fm.teal.alpha namespace.
- Adds social interaction records (post, like, repost) for music sharing
- Implements playlist management with playlist and playlist item records
- Introduces rich text facet support for mentions and links
- Defines shared track view definitions for consistent music metadata
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lexicons/fm.teal.alpha/richtext/facet.json | Adds rich text facet support for mentions and links in posts |
| lexicons/fm.teal.alpha/feed/social/repost.json | Defines repost record structure for sharing posts |
| lexicons/fm.teal.alpha/feed/social/post.json | Main post record with extensive music metadata and social features |
| lexicons/fm.teal.alpha/feed/social/playlistItem.json | Defines individual playlist item structure |
| lexicons/fm.teal.alpha/feed/social/playlist.json | Defines playlist metadata structure |
| lexicons/fm.teal.alpha/feed/social/like.json | Defines like record for post engagement |
| lexicons/fm.teal.alpha/feed/social/defs.json | Shared track view definitions for music metadata |
| lexicons/fm.teal.alpha/feed/play.json | Minor formatting cleanup removing blank line |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
i'm gonna throw badges in here too |
Uh oh!
There was an error while loading. Please reload this page.