Skip to content

Load COL_SCHEMEs from json files #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
baskervald wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Load COL_SCHEMEs from json files #166

baskervald wants to merge 8 commits into from

Conversation

@baskervald
Copy link
Contributor

@baskervald baskervald commented Sep 17, 2015

Based on this format:

{
    "active_tab": {
        "foreground": "light gray",
        "background": "light blue"
    },
    ...
}

tdryer
tdryer reviewed Sep 18, 2015
View reviewed changes
hangups/ui/__main__.py
Copy link
Owner

@tdryer tdryer Sep 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a waste to load all the colour schemes when we already know which one the user wants. Can you make it just load the file that's specified?

@tdryer tdryer mentioned this pull request Nov 1, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baskervald @tdryer