Changing the voice selection

[jpdrecourt]

Hi Thomas,

After trying your code locally on my machine, I only got the German voice. I think it's because the names of the speakers have changed. So here is my suggestion using the language (which should be standard).

By the way, this is my first pull request, so let me know if things didn't go as expected!

Cheers,

JP

[tdodson]

Hi JP,

The pull request looks great and I was able to checkout your branch for testing. What you've done makes perfect sense but I've decided not to merge it with my branch. My reasoning is that I'd like a consistent voice for the English and the Japanese text respectively. When I tested your branch the voice changed from line to line (presumably because there are multiple voices available for each language). I can see how this could be desirable for a different project but not for this one. Thanks!

[jpdrecourt]

Hi Thomas,

Thanks for looking into it. I see that the reason you get random voices is
because I committed more changes afterwards, just for experimenting. I
didn't realise that they would be part of the pull request as well.
Ahem.... still some learning to do here.

My original pull request only called for the first en-US and ja-JP voices,
which should theoretically always be the same. And the reason was that I
didn't have any voices with the names of Daniel and Kyoko. On my Chrome
version, they're just called "Google US English" and "Google 日本語".

I'm happy to look further into it and try to make the necessary changes if
that's useful.

Cheers.

JP

On 3 June 2016 at 14:17, Thomas Dodson notifications@github.com wrote:

Hi JP,

The pull request looks great and I was able to checkout your branch for
testing. What you've done makes perfect sense but I've decided not to merge
it with my branch. My reasoning is that I'd like a consistent voice for the
English and the Japanese text respectively. When I tested your branch the
voice changed from line to line (presumably because there are multiple
voices available for each language). I can see how this could be desirable
for a different project but not for this one. Thanks!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ANYOFTRVb9_V7csuLQtzA1nT0AxKz8Tjks5qICl7gaJpZM4ItYY-
.

[tdodson]

Thanks; very useful. I grabbed a code snippet from one of your earlier commits, tested it on my local copy of the repo, then committed the changes and pushed them to master.

[jpdrecourt]

Great :)
On 3 Jun 2016 4:48 pm, "Thomas Dodson" notifications@github.com wrote:

Thanks; very useful. I grabbed a code snippet from one of your earlier
commits, tested it on my local copy of the repo, then committed the changes
and pushed them to master.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ANYOFdzki3UF9A1i0ufQ86Z_4JurIppoks5qIEy4gaJpZM4ItYY-
.