Sourcery refactored master branch #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourcery-ai
bot
force-pushed
the
sourcery/master
branch
from
efa6742 to
f7ca7c1
Compare
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
|
||
| res = attacker.attack(defender) | ||
| return res | ||
| return attacker.attack(defender) |
Author
There was a problem hiding this comment.
Function do_fight refactored with the following changes:
- Inline variable that is only used once
Comment on lines
-121
to
+120
| fights = [[int(die) for die in fs.split(":")] for fs in fights_str] | ||
| return fights | ||
| return [[int(die) for die in fs.split(":")] for fs in fights_str] |
Author
There was a problem hiding this comment.
Function parse_fights refactored with the following changes:
- Inline variable that is only used once
Comment on lines
-181
to
+185
| # We assume that they will ALWAYS do this, and that the LOSER will | ||
| # never do this | ||
| # We assume that they will ALWAYS do this, and that the LOSER will | ||
| # never do this | ||
| if "cruel" in loser.cards: | ||
| prev_winner = winner | ||
| winner.roll() | ||
| prev_winner.roll() |
Author
There was a problem hiding this comment.
Function Attacker.attack refactored with the following changes:
- Use previously assigned local variable
| return [ | ||
| hand | ||
| for num_cards in range(0, 4) | ||
| for num_cards in range(4) |
Author
There was a problem hiding this comment.
Function get_possible_hands refactored with the following changes:
- Replace range(0, x) with range(x)
| def parse_fights(fights_str): | ||
| fights = [[die_face(die) for die in fs.split(":")] for fs in fights_str] | ||
| return fights | ||
| return [[die_face(die) for die in fs.split(":")] for fs in fights_str] |
Author
There was a problem hiding this comment.
Function parse_fights refactored with the following changes:
- Inline variable that is only used once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: