feat: create custom fn to use git exclude folder and file#55
feat: create custom fn to use git exclude folder and file#55tcelestino merged 2 commits intomainfrom
Conversation
Summary of ChangesHello @tcelestino, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Zsh custom function designed to streamline the process of adding files and folders to Git's local exclusion list. This utility provides a convenient command-line interface for users to manage their Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new shell function, ignore_from_git, to add entries to the .git/info/exclude file. The overall idea is useful. My review includes feedback to improve the function's robustness, adherence to shell scripting best practices, and overall simplicity. Specifically, I've suggested a more reliable way to detect a git repository, recommended redirecting error messages to stderr, and proposed a much simpler and more portable way to check for existing patterns in the exclude file.
68dee42 to
e89a892
Compare
Changelog
.gitfolder.Checklist
Choose the appropriate options: